Report invalid port statuses.

cmd.c

@@ -198,16 +198,32 @@ bool parse_command(struct videohub_data *d, char *cmd) {
 			break;
 		case PARSE_STATUS:
 			s_port->port[port_num].status = S_UNKNOWN;
-			if (streq("BNC", port_data))          s_port->port[port_num].status = S_BNC;
-			else if (streq("Optical", port_data)) s_port->port[port_num].status = S_OPTICAL;
-			else if (streq("RS422", port_data))   s_port->port[port_num].status = S_RS422;
-			else if (streq("None", port_data))    s_port->port[port_num].status = S_NONE;
-			else if (streq("Thunderbolt", port_data)) s_port->port[port_num].status = S_THUNDERBOLT;
+			bool invalid_status = false;
+			if (v->cmd == CMD_SERIAL_PORT_STATUS) {
+				if (streq("RS422", port_data))        s_port->port[port_num].status = S_RS422;
+				else if (streq("None", port_data))    s_port->port[port_num].status = S_NONE;
+				else invalid_status = true;
+			} else {
+				if (streq("BNC", port_data))          s_port->port[port_num].status = S_BNC;
+				else if (streq("Optical", port_data)) s_port->port[port_num].status = S_OPTICAL;
+				else if (streq("None", port_data))    s_port->port[port_num].status = S_NONE;
+				else if (streq("Thunderbolt", port_data)) s_port->port[port_num].status = S_THUNDERBOLT;
+				else invalid_status = true;
+			}
+			if (invalid_status) {
+				q("WARNING: %s command returned unknown status: '%s'\n", cmd_txt, port_data);
+				q("Please report this line to author's email: georgi@unixsol.org\n");
+			}
 			break;
 		case PARSE_DIR:
 			s_port->port[port_num].direction = DIR_AUTO;
 			if (streq("control", port_data))      s_port->port[port_num].direction = DIR_CONTROL;
 			else if (streq("slave", port_data))   s_port->port[port_num].direction = DIR_SLAVE;
+			else if (streq("auto", port_data))    s_port->port[port_num].direction = DIR_AUTO;
+			else {
+				q("WARNING: %s command returned unknown direction: '%s'\n", cmd_txt, port_data);
+				q("Please report this line to author's email: georgi@unixsol.org\n");
+			}
 			break;
 		case PARSE_ROUTE:
 			dest_port_num = strtoul(port_data, NULL, 10);

test/input-14.txt

@@ -9,7 +9,7 @@ Video inputs: 16
 Video processing units: 0
 Video outputs: 16
 Video monitoring outputs: 0
-Serial ports: 0
+Serial ports: 4
 
 INPUT LABELS:
 0 Windows 1
@@ -83,3 +83,33 @@ VIDEO OUTPUT ROUTING:
 14 -1
 15 15
 
+VIDEO OUTPUT STATUS:
+0 BNC
+1 None
+2 Optical
+3 Thunderbolt
+4 Something unknown
+5 RS422
+
+SERIAL PORT LABELS:
+0 Remote 1
+1 Remote 2
+2 Remote 3
+3 Remote 4
+
+SERIAL PORT DIRECTIONS:
+0 auto
+1 control
+2 slave
+3 Wrong direction
+
+UNKNOWN COMMAND:
+0 Something
+1 Something Else
+
+SERIAL PORT STATUS:
+0 BNC
+1 Optical
+2 Thunderbolt
+3 RS422
+

test/test-14.ok

@@ -3,6 +3,26 @@ WARNING: OUTPUT LABELS: invalid video output port 17 (valid 0..15)
 WARNING: VIDEO OUTPUT LOCKS: invalid video output port 19 (valid 0..15)
 WARNING: VIDEO OUTPUT ROUTING: invalid video output port 66 (valid 0..15)
 WARNING: VIDEO OUTPUT ROUTING: invalid video input port 99 (valid 0..15)
+WARNING: VIDEO OUTPUT STATUS command returned unknown status: 'Something unknown'
+Please report this line to author's email: georgi@unixsol.org
+WARNING: VIDEO OUTPUT STATUS command returned unknown status: 'RS422'
+Please report this line to author's email: georgi@unixsol.org
+WARNING: SERIAL PORT DIRECTIONS command returned unknown direction: 'Wrong direction'
+Please report this line to author's email: georgi@unixsol.org
+WARNING: Videohub sent unknown command!
+         Please report this command to author's email: georgi@unixsol.org
+         You may use -q or --quiet to suppress the message.
+---------8<-----------8<----------- cut here ---------8<------------8<---------
+UNKNOWN COMMAND:
+0 Something
+1 Something Else
+---------8<-----------8<----------- cut here ---------8<------------8<---------
+WARNING: SERIAL PORT STATUS command returned unknown status: 'BNC'
+Please report this line to author's email: georgi@unixsol.org
+WARNING: SERIAL PORT STATUS command returned unknown status: 'Optical'
+Please report this line to author's email: georgi@unixsol.org
+WARNING: SERIAL PORT STATUS command returned unknown status: 'Thunderbolt'
+Please report this line to author's email: georgi@unixsol.org
 Device info
   -----------------------------------------------------------
   | Device address             | sdi-matrix                 |
@@ -12,6 +32,7 @@ Device info
   | Protocol                   | 2.4                        |
   | Video inputs               | 16                         |
   | Video outputs              | 16                         |
+  | Serial ports               | 4                          |
   -----------------------------------------------------------
 
 Video inputs
@@ -44,10 +65,10 @@ Video outputs
   --------------------------------------------------------------------
   | ## | x | Video output name        | Connected video input    | s |
   --------------------------------------------------------------------
-  |  1 | L | Enc1 1                   | Windows 3                |   |
-  |  2 | L | Enc1 2                   | Windows 2                |   |
-  |  3 | L | Enc1 3                   | Windows 1                |   |
-  |  4 | L | Enc1 4                   | Windows 1                |   |
+  |  1 | L | Enc1 1                   | Windows 3                | B |
+  |  2 | L | Enc1 2                   | Windows 2                | x |
+  |  3 | L | Enc1 3                   | Windows 1                | o |
+  |  4 | L | Enc1 4                   | Windows 1                | T |
   |  5 |   | Output 5                 | Input 5                  |   |
   |  6 |   | Output 6                 | Input 6                  |   |
   |  7 |   | Output 7                 | Windows 1                |   |
@@ -62,3 +83,13 @@ Video outputs
   | 16 |   | Loopback                 | Loopback                 |   |
   --------------------------------------------------------------------
 
+Serial ports
+  ---------------------------------------------------------------
+  | ## | x | Dir  | Serial port        | Connected serial   | s |
+  ---------------------------------------------------------------
+  |  1 |   | auto | Remote 1           |                    |   |
+  |  2 |   |   in | Remote 2           |                    |   |
+  |  3 |   |  out | Remote 3           |                    |   |
+  |  4 |   | auto | Remote 4           |                    | 4 |
+  ---------------------------------------------------------------
+